Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check SubSelectPalettesListener if we can not work without DCA #46

Open
zonky2 opened this issue Feb 4, 2022 · 1 comment
Open

Check SubSelectPalettesListener if we can not work without DCA #46

zonky2 opened this issue Feb 4, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@zonky2
Copy link
Contributor

zonky2 commented Feb 4, 2022

my be..??

in https://github.com/contao-community-alliance/meta-palettes/blob/7a34d0ae2bca73ac649c4256853f82245e1bc5ec/src/Listener/SubSelectPalettesListener.php

see

// We can not work without DCA.
if (!(isset($GLOBALS['TL_DCA'][$strTable]) && is_array($GLOBALS['TL_DCA'][$strTable]))) {
return;
}
// The MetaPalettesBuilder is used for DC_General
if (isset($GLOBALS['TL_DCA'][$strTable]['config']['dataContainer'])
&& $GLOBALS['TL_DCA'][$strTable]['config']['dataContainer'] == 'General'
) {
return;
}

@zonky2 zonky2 added the Question label Feb 4, 2022
@zonky2 zonky2 added this to the 2.1.0 milestone Feb 4, 2022
@dmolineus
Copy link
Member

The SubSelectPalettesListener is only registered after the mentioned check above. So afaik it's not required adding the check again.

$this->registerSubSelectPalettesCallback($strTable);

However #44 indicates that the DC General mix something up so that the issue occurs. Imho this has to be checked at the DC General site first, how #44 could ever happen. /cc @baumannsven

@zonky2 zonky2 modified the milestones: 2.1.0, 2.1.2, 2.1.3 Jan 18, 2023
@dmolineus dmolineus modified the milestones: 2.1.3, Future Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants