-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Validation Status #788
Comments
Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Once all required labels are present, please add |
✅ Jira issue https://jira.corp.adobe.com/browse/CAI-7462 is successfully created for this GitHub issue. |
This was lost as part of the transition to the new Reader API. It will be restored in a new and better format as validation_results with the addition of claims v2 support. |
The problem is, without validation_status, c2patool does not identify what was evaluation. We only know that the unknown elements that were evaluated appear to be valid. The validation_status block is essential because it identifies what was evaluated as well as the evaluation results. |
The new version of c2patool (0.13.1) now includes validation_results in the detailed report. The validation_results filed is a more structured version of status reporting matching the c2pa 2.1 specification. It separates the active_manifest status codes and any delta changes from each ingredient. The codes are further divided into success, informational and failure. |
Confirmed: 0.13.1 with -d displays the validation status. You changed the output format, splitting out success, informational, and failure. Probably a good idea, but it was an unexpected code change that will require a rewrite on my code that was looking for the previous format. |
c2patool 0.10.2: it no longer displays the "validation_status" block. For example (https://fotoforensics.com/analysis.php?id=9319b3d54148ccb21a6dd3947cfae4766f8ae4f4.394694&fmt=orig): c2patool 0.7.0 through 0.9.10 with -d includes a "validation_status" summary, showing which claims and assertions are validated.
But 0.10.x omits this validation_status information, so the caller cannot determine if the file is actually valid.
The text was updated successfully, but these errors were encountered: