ResourceSet resources namespace should default to current namespace?

[erikgb]

During my initial experiments with the new ResourceSet, I was surprised to see that there was no default namespace applied to the ResourceSet resources. It is not obvious that it should have this default, because I imagine someone would like to manage cluster-scoped resources. But as a user, I would expect that a namespaced resource like ResourceSet would normally manage resources in the same namespace by default.

[stefanprodan]

It's the same as with a Flux Kustomization, it's up to the user to define a namespace and we don't do what kubectl does where things end in default.

[erikgb]

It's the same as with a Flux Kustomization, it's up to the user to define a namespace and we don't do what kubectl does where things end in default.

Trying to put anything in the default namespace by default is not a good idea here. IMO ResourceSet has a more "in-line" spec than Flux Kustomization, so I don't think that's a fair comparison. 😉 But I understand that adding a default namespace would limit the use cases. What do you think about adding an optional field to the ResourceSet spec allowing the user to set a default for the resources managed by the ResourceSet? In this case, a normal multi-tenant user, who typically would use this to provision a set of similar applications, would not have to put the namespace on every resource.

[stefanprodan]

Maybe this could go under commonMetadata where you can set common labels and annotations.

[erikgb]

Maybe this could go under commonMetadata where you can set common labels and annotations.

Yes, that sounds like a good spot for this! ❤ Maybe also add name, if this is ever implemented? Less applicable than namespace, but I could see use cases for that as well.

[stefanprodan]

Another option would be to expose the ResourceSet metadata as template vars. So you could use these anywhere in .spec.resources and .spec.resourcesTemplate:

• << rset.name >>
• << rset.namespace >>
• << rset.labels >>
• << rset.annotations >>

You would still need to set namespace everywhere, but instead of a hardcoded value in templates, it would come from the ResourceSet metadata.

[matheuscscp]

Could we have both the rset template var, then after templating if the metadata fields are empty we default to commonMetadata if they are set?

[stefanprodan]

if the metadata fields are empty we default to commonMetadata if they are set?

No this would be a breaking change, commonMetadata overrides whatever is in templates.

[matheuscscp]

Then we could still have both, but then we would override with commonMetadata if the field is set, even if after templating the respective field is already set

[matheuscscp]

E.g. if commonMetadata.namespace is set we override, otherwise we leave whatever was the output of the template (which can be << rset.namespace >>)