Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLG_SYSTEM_ENVIRONMENTDETECT_CANT_DETECT_SYSTEM #12

Open
pe7er opened this issue Feb 20, 2020 · 7 comments
Open

PLG_SYSTEM_ENVIRONMENTDETECT_CANT_DETECT_SYSTEM #12

pe7er opened this issue Feb 20, 2020 · 7 comments

Comments

@pe7er
Copy link

pe7er commented Feb 20, 2020

At https://browsercache-legen.nl/ on the English language I click on "Detect my Browser", then on my Linux machine with Chrome/Firefox appears the following message:
"Sorry we have no descriptions for your operating system"

When I use the Dutch or French language, the language string is not translated and
PLG_SYSTEM_ENVIRONMENTDETECT_CANT_DETECT_SYSTEM
appears instead.

@zero-24
Copy link

zero-24 commented Mar 2, 2020

The message comes from my plugin: https://github.com/zero-24/plg_system_environmentdetect

Can you send the correct translation there? This should than make them available with the next update :)

Usually I would expect the en-GB file to be loaded when there is no dedicated file for the choosen language maybe @coolcat-creations can take a look and share the language debug console which file joomla tries to load?

"Sorry we have no descriptions for your operating system"

This also seams to be not the original message? Maybe an intended override? I'm happy to apply such changes to the original plugin for sure :)

@pe7er
Copy link
Author

pe7er commented Mar 3, 2020

@coolcat-creations Could you add your Dutch language file to https://github.com/zero-24/plg_system_environmentdetect/tree/master/language ?

@zero-24 I would translate PLG_SYSTEM_ENVIRONMENTDETECT_CANT_DETECT_SYSTEM to:
"Sorry, er is geen beschrijvingen beschikbaar voor uw besturingssysteem"

@coolcat-creations
Copy link
Owner

Thank you, I will do.

@coolcat-creations
Copy link
Owner

I added the language files to the original Plugin repo, but I can't fnd why the plugin does not load the language files. Maybe it has to do with the multidomain plugin? Debugging does not work at all.

@zero-24
Copy link

zero-24 commented Mar 11, 2020

Debugging does not work at all.

Debugging does not work at all?

@coolcat-creations
Copy link
Owner

No, maybe because of the language filter plugin. I don't see any debugging console even if turned on.

@zero-24
Copy link

zero-24 commented Mar 15, 2020

Please check: https://github.com/zero-24/plg_system_environmentdetect/releases/tag/1.0.3 This adds the translations and also moves the ini to sys.ini files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants