Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive/sizeMapping returning wrong sizes #150

Open
ozeone opened this issue May 14, 2018 · 4 comments
Open

Responsive/sizeMapping returning wrong sizes #150

ozeone opened this issue May 14, 2018 · 4 comments

Comments

@ozeone
Copy link

ozeone commented May 14, 2018

Hello & thanks for an awesome script.
I am trying to set up a responsive pushdown panorama banner using 4 different sizes (3 breakpoints).
Banner load fine but the actual size mapping seems to be lost, all banners seem to load random no matter window size :/

Pen: https://codepen.io/martink/full/zjLrbx/

I don't know what i am doing wrong here, according to all posts i find about this its the correct markup (or i have missed something vital?)

Best regards

Martin

@ozeone
Copy link
Author

ozeone commented May 14, 2018

image

The line items

@omelsoft
Copy link

In your ad tag, you should specify the data-size-mapping attribute not data-dimensions. With data-dimensions, it will randomly pick a creative size depending on your line items settings.

@ozeone
Copy link
Author

ozeone commented May 21, 2018

@omelsoft I have updated the pen and banners load, but its still the same result (mobile showing random no matter browser size), can you see what i am doing wrong?
I ma using both data-dimensions and data-size-mapping with the same values, is this the way to do it?

Feel free to update/fork pen ;) And thanks for helpinig

@ozeone
Copy link
Author

ozeone commented May 22, 2018

just got this to work i think, misunderstood the use data-size-mapping from start :/
I changed data-size-mapping to be the name of the size mapping (makes sense) and everything started working :)

Final working pen: https://codepen.io/martink/pen/zjLrbx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants