-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive/sizeMapping returning wrong sizes #150
Comments
In your ad tag, you should specify the data-size-mapping attribute not data-dimensions. With data-dimensions, it will randomly pick a creative size depending on your line items settings. |
@omelsoft I have updated the pen and banners load, but its still the same result (mobile showing random no matter browser size), can you see what i am doing wrong? Feel free to update/fork pen ;) And thanks for helpinig |
just got this to work i think, misunderstood the use data-size-mapping from start :/ Final working pen: https://codepen.io/martink/pen/zjLrbx |
Hello & thanks for an awesome script.
I am trying to set up a responsive pushdown panorama banner using 4 different sizes (3 breakpoints).
Banner load fine but the actual size mapping seems to be lost, all banners seem to load random no matter window size :/
Pen: https://codepen.io/martink/full/zjLrbx/
I don't know what i am doing wrong here, according to all posts i find about this its the correct markup (or i have missed something vital?)
Best regards
Martin
The text was updated successfully, but these errors were encountered: