Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivating a job is not transitive #90

Open
eponier opened this issue Jan 6, 2022 · 2 comments
Open

Deactivating a job is not transitive #90

eponier opened this issue Jan 6, 2022 · 2 comments

Comments

@eponier
Copy link

eponier commented Jan 6, 2022

It seems like setting job = false for a reverse dependency does not disable reverse dependencies of this reverse dependency.

For instance, in this commit of coq-elpi, we tried to disable hierarchy-builder (this is commented out, the bug appears if you uncomment the appropriate line), and this did not disable graph-theory and mathcomp-analysis, that are both reverse dependencies of hierarchy-builder, but not direct reverse dependencies of coq-elpi. We had to also disable these two packages manually.

@CohenCyril
Copy link
Collaborator

@Zimmi48 I think this might be related to one of your issues... (I cannot recall which one)

@Zimmi48
Copy link
Member

Zimmi48 commented Jan 8, 2022

This is similar to the issue that we were having when filtering jobs out of coqPackages but that would not filter their reverse dependencies (which would then fail to evaluate). The attempted fix is there: NixOS/nixpkgs#141260

However, this is not the same issue, because disabling a job in CI should not mean marking it as broken / filtering it out (there should be distinct ways of doing each). This is something that I complain about in #62.

Finally, note that until we have #84 implemented, it can actually be useful to disable a job without disabling its reverse dependencies to gather them in a single job (this is what I had done for category-theory, though my PR adding Coq Nix Toolbox support was not merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants