Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show zaps with a message #547

Open
staab opened this issue Jan 22, 2025 · 2 comments
Open

Show zaps with a message #547

staab opened this issue Jan 22, 2025 · 2 comments
Assignees
Milestone

Comments

@staab
Copy link
Collaborator

staab commented Jan 22, 2025

The tricky thing is that lots of messages are boilerplate. Maybe we can do this, maybe not.

@staab staab added this to the 0.6.0 milestone Jan 22, 2025
@staab staab modified the milestones: 0.6.0, 0.7.0 Jan 22, 2025
@ticruz38
Copy link
Collaborator

Show the message only for the largest zap? All zaps? Under the note? In a feed?

@staab
Copy link
Collaborator Author

staab commented Jan 23, 2025

Run this in the console to get a list of zap messages by how many times they show up:

groupBy(identity, repository.query([{kinds: [ZAP_RESPONSE]}]).map(e => e.content || JSON.parse(e.tags.find(t => t[0] === 'description')[1]).content).filter(identity))

I was originally thinking of showing these as replies. But most appear to be either emojis or ads. Since we don't show reaction emojis anyway, there's no need to show zap emojis. Other messages don't seem to add much, but it's a shame to allow users to provide messages, but then ignore them. So I think the best way to solve this would be to address this on the notifications page via NoteMeta (see recent update).

This means that this should be pretty simple; the zap section in NoteMeta will just have to be updated to show zap content. While you're at it, we might as well show a full summary there rather than just the first zap/repost/reaction. Here's what it currently looks like:

Image

This is sort of weird, because it doesn't say what the other 15 people did. Of course, showing all activity might make NoteMeta too unwieldy in a feed context, so it's possible we'll want to add a mode flag to NoteMeta, or create a separate component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants