Crash when creating DTMF sender - rtcPeerConnection.senders array is empty

[RaddishIoW]

I've got a crash happening every time I try to make or receive a call in my app...
It crashes when trying to create the DTMF sender because the passed rtcPeerConnection.senders array is empty, but the plugin is trying to access element 0.

The crash happens here in the plugin code.

I can't seem to work out why it might be happening, but I am very new to WebRTC - so please forgive my ignorance.

Does anyone have any pointers?

I'm using Capacitor 4, with Sip.JS 0.21.2 and iosrtc 8.0.3.

[hthetiot]

@RaddishIoW it's clearly a bug, can be fixed in the line you found that use first entry on empty array.

I may take a look later, when I have a moment, alternatively PR is welcome.

[RaddishIoW]

OK - I didn't want to report it as an issue in case it was just my fault for not setting it up properly! :)

If I guard against the assumption that the array isn't empty, would that be an acceptable solution for a PR? I see that after the problem line, there is a guard against the result being nil, so I think it should work.

[VeaceslavB]

We face the same issue with the latest twilio sdk

[hthetiot]

@RaddishIoW made a PR here:

• fix: guard against empty senders array #764

I will release when I have a moment. In the mean time you can test the fix like that:

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/RaddishIoW/cordova-plugin-iosrtc#RaddishIoW-DTMFinit-patch
cordova platform remove ios --no-save
cordova platform add ios --no-save

[angelicamapeso]

Attempted to use this fix as we were running into the same issue with the latest twilio sdk, but the app still crashed. However, it crashed in a different place now but with the same message of trying to access an empty array at index 0.

Here's some logs:

[hthetiot]

Thank you @angelicamapeso yes, I suspected much, I will apply more fix to the PR when I have a moment.

[hthetiot]

Fix by fix PluginRTCDTMFSender insertDTMF when no senders is available #770 also make sure you force unified-plan as iosrtc default is plan-b and cause sender to not be used unless unified-plan is used.