Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In check_required_attrs we need to also check for values #28

Open
coreyjs opened this issue Jun 3, 2020 · 1 comment
Open

In check_required_attrs we need to also check for values #28

coreyjs opened this issue Jun 3, 2020 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@coreyjs
Copy link
Owner

coreyjs commented Jun 3, 2020

A required attribute should also have a value, just just its inclusion in the args.

# TODO need to also check that these required attributes have values

In a mutation, when we mark an attribute as being required using the method required_attr :my_attr, the presence alone should not be an indication of requirement but it should also be a non nil value.

@coreyjs coreyjs added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Jun 3, 2020
@coreyjs coreyjs removed the good first issue Good for newcomers label Sep 5, 2020
@coreyjs
Copy link
Owner Author

coreyjs commented Sep 5, 2020

note, I need to update this ticket with some more information.

@coreyjs coreyjs self-assigned this Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant