Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command data type #4

Open
sinamr88 opened this issue Jun 16, 2016 · 10 comments
Open

Command data type #4

sinamr88 opened this issue Jun 16, 2016 · 10 comments

Comments

@sinamr88
Copy link

An integer :D

@xwavex
Copy link
Collaborator

xwavex commented Jun 16, 2016

Can you please explain a bit more? :)

@sinamr88
Copy link
Author

sinamr88 commented Jun 16, 2016

It could be nice to have a integer data type to publish commands . The dimension of the data type is 1. It is enough, but it would be more appropriated to be timestamped and have a string with it.

@xwavex
Copy link
Collaborator

xwavex commented Jun 16, 2016

Quick draft? Is this how you imagine the type? Can you make an example, for what application would you use this type? :)

data-type-name: {
    - int cmd
    - string description?
    - time timestamp
}

@sinamr88
Copy link
Author

sinamr88 commented Jun 16, 2016

The data-type-name is perfect.

@ndehio
Copy link
Collaborator

ndehio commented Nov 8, 2016

Why don't you sent an integer or float directly? I don't think we need a specific type for that. Which advantage do you expect from creating such a type?

@xwavex
Copy link
Collaborator

xwavex commented Nov 8, 2016

As far as I understood, the timestamp is needed, which is not persisted by the Orocos transport itself.

@sinamr88
Copy link
Author

sinamr88 commented Nov 8, 2016

@ndehio You are right....but It makes the code more readable for others..:)

@xwavex
Copy link
Collaborator

xwavex commented Nov 8, 2016

@sinamr66 How soon to you need this data type?

@sinamr88
Copy link
Author

sinamr88 commented Nov 8, 2016

Not soon..:D

@xwavex
Copy link
Collaborator

xwavex commented Nov 8, 2016

Ok good to know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants