Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide official test vectors #38

Open
dajiaji opened this issue Oct 9, 2023 · 1 comment
Open

Provide official test vectors #38

dajiaji opened this issue Oct 9, 2023 · 1 comment

Comments

@dajiaji
Copy link
Contributor

dajiaji commented Oct 9, 2023

@hannestschofenig @selfissued @OR13 and other folks,

I think Orie also mentioned this in another issur/PR, but how about providing test vectors in the COSE-HPKE spec?

Since the COSE specs are referred by many IETF WGs such as SUTE, TEEP, RATS, SCITT, etc., I think it is better for the COSE WG to provide the official test vectors.

Here are my suggestions:

  • Create a test-vectors repository under the cose-wg group on github (cose-wg/test-vectors).
  • Create comprehensive test-vectors for COSE-HPKE spec in this repository
  • Pick out a few typical ones from the repository's test-vectors and list them in the appendix in the COSE-HPKE spec with a link to the repository.

HPKE spec (RFC9180) also provides test vectors in the same manner.

What do you think?

@OR13
Copy link
Contributor

OR13 commented Oct 9, 2023

I think we should do a PR to :

under a new directory called hpke-examples

I'd recommend generating the examples from a repo that maintains an implementation, so we can regenerate them again later if needed.

Here is a similar project that uses YAML to maintain examples:

https://github.com/openwallet-foundation-labs/sd-jwt-python

An example spec file, that is used to generate examples:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants