Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit x/tx v0.47...v0.50 #16981

Closed
facundomedica opened this issue Jul 13, 2023 · 2 comments
Closed

Audit x/tx v0.47...v0.50 #16981

facundomedica opened this issue Jul 13, 2023 · 2 comments
Assignees
Labels

Comments

@facundomedica
Copy link
Member

No description provided.

@facundomedica facundomedica mentioned this issue Jul 13, 2023
52 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jul 13, 2023
@tac0turtle tac0turtle added T:Sprint T: Audit and removed needs-triage Issue that needs to be triaged labels Jul 18, 2023
@facundomedica
Copy link
Member Author

Overall lgtm, my confidence is low on my audit here tho, I'm not too familiar with it:

  • Lots of new code
  • We might want to add more tests to ensure compatibility of AminoJSON (coverage is 51% right now)
  • textual was audited recently by internal and external auditors

I'll do another round later this week/next week

@alexanderbez
Copy link
Contributor

As mentioned previously, this package introduced a fair amount of new code and moving existing pieces from other packages. After reviewing the code, I can't see anything major concerns apart from low test coverage as @facundomedica mentioned. General overview of changes:

  • Context type
  • Signer mode and signer data
  • Signing mode implementations
    • Textual needs more test coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants