Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit client v0.47..v0.50 #17013

Closed
tac0turtle opened this issue Jul 16, 2023 · 5 comments · Fixed by #17051
Closed

Audit client v0.47..v0.50 #17013

tac0turtle opened this issue Jul 16, 2023 · 5 comments · Fixed by #17051
Assignees
@tac0turtle @julienrbrt
Labels
T: Audit

Comments

@tac0turtle
Copy link
Member

No description provided.

@tac0turtle tac0turtle mentioned this issue Jul 16, 2023
Closed
52 tasks
@tac0turtle tac0turtle self-assigned this Jul 16, 2023
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jul 16, 2023
@tac0turtle tac0turtle added T:Sprint T: Audit and removed needs-triage Issue that needs to be triaged labels Jul 16, 2023
@tac0turtle
Copy link
Member Author

other than changes from tendermint -> comet and the addition of sign mode textual there were no medium to major changes. This version introduced client/v2 which was avoided as part of the read through

@julienrbrt julienrbrt self-assigned this Jul 18, 2023
@julienrbrt
Copy link
Member

julienrbrt commented Jul 18, 2023 •
edited
Loading

image
Woah 🥲

EDIT: ah better

image

@alexanderbez
Copy link
Contributor

🔥 what does :!client/v2 do?

@tac0turtle
Copy link
Member Author

autocli

@julienrbrt
Copy link
Member

Haven't found anything either. I haven't try locally to use Sign Mode Textual, but as this has been audited separately it is fine. #17047 bring to our attention that no all swagger modules have been added in the configs file. So opening a PR closing this that fixes it.

@julienrbrt julienrbrt mentioned this issue Jul 18, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

@julienrbrt julienrbrt

Labels
T: Audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(client): add missing modules from swagger cosmos/cosmos-sdk
3 participants
@alexanderbez @tac0turtle @julienrbrt