Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long simulations #21415

Closed
julienrbrt opened this issue Aug 27, 2024 · 1 comment · Fixed by #21503
Closed

Fix long simulations #21415

julienrbrt opened this issue Aug 27, 2024 · 1 comment · Fixed by #21503
Assignees
@alpe
Labels
T:Bug T: Tests

Comments

@julienrbrt
Copy link
Member

Long simulation have been failing for a while: https://github.com/cosmos/cosmos-sdk/actions/workflows/sims-nightly.yml
We should check what's wrong, fix it and backport to 0.52
@alpe alpe self-assigned this Sep 2, 2024
@alpe
Copy link
Contributor

alpe commented Sep 2, 2024

Some details
The last good run was at #10465a6
The first failing one in the row: #a22592a

In the diff the call to app.SimWriteState() was added to persist the transient multistore on commit. This call makes sense so that the sims can build state.
I don't know why this fails on the CI box. I have confirmed that they pass on 2 other computers (OSX).

@alpe alpe mentioned this issue Sep 3, 2024
Merged
@mergify mergify bot mentioned this issue Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alpe alpe

Labels
T:Bug T: Tests
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sims): OOM at sim-multi-seed-long run cosmos/cosmos-sdk
2 participants
@alpe @julienrbrt