Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump app version after upgrade in v2 path #21418

Closed
julienrbrt opened this issue Aug 27, 2024 · 0 comments · Fixed by #21508
Closed

Bump app version after upgrade in v2 path #21418

julienrbrt opened this issue Aug 27, 2024 · 0 comments · Fixed by #21508
Assignees
Labels
C:server/v2 Issues related to server/v2

Comments

@julienrbrt
Copy link
Member

ref: #16455, #21176

Baseapp implements the version modifier:
https://github.com/cosmos/cosmos-sdk/blob/3e41324/core/app/app.go#L70-L77

x/upgrade updates that version modifier in

if k.versionModifier != nil {
, which is then returned in abci_info.

On server/v2 we get them from x/consensus params:

appVersion = cp.Version.GetApp()
but don't upgrade them in x/upgrade

Proposal

  • Update app version in baseapp (done) and server/v2
  • Remove VersionModifier from core/server as it is baseapp specific
  • Or make the version update consistent between baseapp & server/v2 to not have two different handling in x/upgrade

Requirements: Do not introduce a x/consensus dependency in x/upgrade (as this module is cometbft specific).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

2 participants