From 6c23a791101162f2defd7667a714869faa3d3325 Mon Sep 17 00:00:00 2001 From: Tyler <48813565+technicallyty@users.noreply.github.com> Date: Thu, 30 Jan 2025 10:59:55 -0800 Subject: [PATCH] check ack nil --- modules/core/keeper/msg_server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/core/keeper/msg_server.go b/modules/core/keeper/msg_server.go index 1dbec1870c8..0e0d6be4082 100644 --- a/modules/core/keeper/msg_server.go +++ b/modules/core/keeper/msg_server.go @@ -399,7 +399,7 @@ func (k *Keeper) RecvPacket(ctx context.Context, msg *channeltypes.MsgRecvPacket if err := k.BranchService.Execute(ctx, func(subCtx context.Context) error { // Perform application logic callback ack = cbs.OnRecvPacket(subCtx, channelVersion, msg.Packet, relayer) - if !ack.Success() { + if ack != nil && !ack.Success() { // we must return an error here so that false positive events are not emitted events = sdk.UnwrapSDKContext(subCtx).EventManager().Events() return channeltypes.ErrFailedAcknowledgement