Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for multi-denom transfer #249

Closed
gjermundgaraba opened this issue Jan 30, 2025 · 1 comment
Closed

Add tests for multi-denom transfer #249

gjermundgaraba opened this issue Jan 30, 2025 · 1 comment
Labels
20-transfer Issues related to the ICS20 application testing Issues related to testing

Comments

@gjermundgaraba
Copy link
Contributor

In #114, we added support for ICS20v2, which has multi-denom support. It means it can transfer and receive multiple denoms at a time, which needs proper testing.

Add at least the following tests:

  • Unit case in test_newMsgSendPacketV2
  • Unit tests (happy path and at least one failure case) for both send and receive in ICS20TransferTest.t.sol
  • Unit tests for both send and receive in IntegrationTests.t.sol
  • E2E test with both send and receive (e.g. Eth -> Cosmos -> Eth)
@gjermundgaraba gjermundgaraba added 20-transfer Issues related to the ICS20 application testing Issues related to testing labels Jan 30, 2025
@srdtrk
Copy link
Member

srdtrk commented Feb 6, 2025

We won't be including ICS20-v2 in the initial release

@srdtrk srdtrk closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in IBC-GO Eureka Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-transfer Issues related to the ICS20 application testing Issues related to testing
Projects
Status: Done
Development

No branches or pull requests

2 participants