You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Additional context
While I was using this and the docs yesterday I noticed that the was a discrepancy between the props I saw in the code and the documentation in Storybook for the modal component. Long story short (and after about 8 hours trying to fix it yesterday) I couldn't find a way to get it to show up in story book.
Customizing the modal.story.js to create a wrapper component for the modal with for it so I could manually add the args. (https://storybook.js.org/addons/storybook-addon-react-docgen) (also didn't work... I thinks its because storybook still can't digest the Modal props and this just modifies ones it matches.)
Manually creating the table (doesn't work so well since story book uses CSS Modules)
I'm wondering if anyone else has tried to fix this and what they've tried. At this point I'm stumped. The next thing I'd want to try is pretty drastic (redo the storybook config and use DocPages instead of MDX as a default) but I didn't think the repo maintainers would be onborad with such a drastic change.
The other thing I wondered is if we could somehow change the modal code so that storybook-addon-react-docgen would actually pick it up the props. I'm not exactly sure why it's not picking them up but I'm thinking it's related to one of the things mentioned in (FAQ - Nothing shows up, this is broken!) section on this page.
This is a great repo and I can tell you've put in a lot of work into this so far and I'd love to contribute but since I'm still fairly new to it I'm wondering if the primary maintainers have any ideas on this.
The text was updated successfully, but these errors were encountered:
Describe the bug
Storybook not rendering ArgsTable for Modal
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The props for the modal component should be displayed.
(https://github.com/couds/react-bulma-components/blob/master/src/components/modal/modal.js)
Screenshots
Versions
react-bulma-components:
: 4.0.7bulma
: 0.9.2react
: 17.0.2Additional context
While I was using this and the docs yesterday I noticed that the was a discrepancy between the props I saw in the code and the documentation in Storybook for the modal component. Long story short (and after about 8 hours trying to fix it yesterday) I couldn't find a way to get it to show up in story book.
Things I've tried (a.k.a. the long story):
I'm wondering if anyone else has tried to fix this and what they've tried. At this point I'm stumped. The next thing I'd want to try is pretty drastic (redo the storybook config and use DocPages instead of MDX as a default) but I didn't think the repo maintainers would be onborad with such a drastic change.
The other thing I wondered is if we could somehow change the modal code so that storybook-addon-react-docgen would actually pick it up the props. I'm not exactly sure why it's not picking them up but I'm thinking it's related to one of the things mentioned in (FAQ - Nothing shows up, this is broken!) section on this page.
This is a great repo and I can tell you've put in a lot of work into this so far and I'd love to contribute but since I'm still fairly new to it I'm wondering if the primary maintainers have any ideas on this.
The text was updated successfully, but these errors were encountered: