Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds are deployed on the wrong branch #34

Open
y-lohse opened this issue Dec 20, 2019 · 4 comments
Open

CI builds are deployed on the wrong branch #34

y-lohse opened this issue Dec 20, 2019 · 4 comments

Comments

@y-lohse
Copy link
Contributor

y-lohse commented Dec 20, 2019

Despite this, it seems that CI builds still land on the build branch. It probably comes from the package.json file.

@y-lohse
Copy link
Contributor Author

y-lohse commented Dec 20, 2019

The variablke might need to be exported with env or export so it's available for all commands

@y-lohse
Copy link
Contributor Author

y-lohse commented Jan 6, 2020

There's also a real risk that multiple travis jobs override the build branch if they run at the same time, potentially publishing a version of the app under a different version number. At least the tag version of the deployment should have a dedicated branch name.

@Crash--
Copy link
Contributor

Crash-- commented Jan 22, 2020

We decided to not use a branch to store the build before uploading it to our registry. We want to use downcloud.

See cozy/cozy-passwords#10

@drazik
Copy link
Contributor

drazik commented Jan 23, 2020

Also see cozy/cozy-passwords#11.

And I still have a problem when deploying to the registry with all that: https://travis-ci.org/cozy/cozy-passwords/builds/640547425#L328

I'm looking for a solution. I will keep you informed when I fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants