From 15fe4ce9adc120274e608eae59056f50296a3505 Mon Sep 17 00:00:00 2001 From: Bruno Michel Date: Mon, 2 Jul 2018 18:45:24 +0200 Subject: [PATCH] Fix some missing copies in Clone --- pkg/instance/instance.go | 3 +++ pkg/notification/notifications.go | 2 ++ 2 files changed, 5 insertions(+) diff --git a/pkg/instance/instance.go b/pkg/instance/instance.go index 6d3ccaa5c30..7ab5aa6d250 100644 --- a/pkg/instance/instance.go +++ b/pkg/instance/instance.go @@ -172,6 +172,9 @@ func (i *Instance) SetRev(v string) { i.DocRev = v } func (i *Instance) Clone() couchdb.Doc { cloned := *i + cloned.DomainAliases = make([]string, len(i.DomainAliases)) + copy(cloned.DomainAliases, i.DomainAliases) + cloned.PassphraseHash = make([]byte, len(i.PassphraseHash)) copy(cloned.PassphraseHash, i.PassphraseHash) diff --git a/pkg/notification/notifications.go b/pkg/notification/notifications.go index 9d755463f34..e5da12909f8 100644 --- a/pkg/notification/notifications.go +++ b/pkg/notification/notifications.go @@ -77,6 +77,8 @@ func (n *Notification) Clone() couchdb.Doc { for k, v := range n.Data { cloned.Data[k] = v } + cloned.PreferredChannels = make([]string, len(n.PreferredChannels)) + copy(cloned.PreferredChannels, n.PreferredChannels) return &cloned }