Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect "sponsors" plural in notification emails #1

Open
tm604 opened this issue May 25, 2021 · 0 comments
Open

Incorrect "sponsors" plural in notification emails #1

tm604 opened this issue May 25, 2021 · 0 comments

Comments

@tm604
Copy link

tm604 commented May 25, 2021

The notification template here uses SPONSOR_CATEGORY with the assumption that it's singular:

One of our esteemed sponsors is [% SPONSOR_NAME %], [% IF 'Individual Sponsor' == SPONSOR_CATEGORY ; THEN ; 'an' ; ELSE ; 'a' ; END ; %] [% SPONSOR_CATEGORY %].

However, the values appear to be plural - an example email being:

One of our esteemed sponsors is OpenStrike, a Bronze Sponsors.

There's a .json file in the repo but it's marked as a "fallback", so presumably there's a database driving the real data. If that means it'd be hard to change the category value, one suggested template alternative:

One of our esteemed [% SPONSOR_CATEGORY %][% IF 'Individual Sponsor' == SPONSOR_CATEGORY ; THEN ; 's' ; END ; %] is [% SPONSOR_NAME %].<br class="Apple-interchange-newline">

which should lead to emails with phrasing this:

One of our esteemed Bronze Sponsors is X.
One of our esteemed Individual Sponsors is Y.
One of our esteemed Platinum Sponsors is Z.

(thanks to peregrin for helping me find this repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant