Localizations improvement

[bohdanudreambit]

There are two problems in implementation of localization.

Problem 1. Translate function requires from us to know full and strange keys like this:

locale?.translate(
           ’Review this form below, and tap AGREE if you\’re ready to continue.’) ??
         ’Review this form below, and tap AGREE if you\’re ready to continue.’,

Problem 2. Current implementation can’t properly handle cases when we need to insert variable into random place of the string. RP just concatinates sequance of texts and variables but some languages might require to change the order of words. For example:

_errorMessage =
      “${locale?.translate(‘Should be between’) ?? ‘Should be between’} ${widget.answerFormat.minValue} 
${locale?.translate(‘and’) ?? ‘and’} ${widget.answerFormat.maxValue}“;

Working on the private fork of research package repo for company we faced these issues.
There are great solution to solve these problems.
Solution for Problem 1. Use getters in RPLocalization, for example:
String get reviewAndAgreeToContinue => translate(“reviewAndAgreeToContinue”);
Solution for Problem 2. Use functions similarly to getters, like this one:
String valueShouldBeBetween(Object minValue, Object maxValue);

Our main goals are to stay closer to Flutter internationalization and improve your package. If anybody interested in this idea please let me know and I will create PR soon.

[bardram]

Problem 1 has been fixed in version 0.7.1 for a while. See the tutorial on using localization in Research Package.

However, problem 2 is more fundamental. I would like to get input on this. One idea is to use $ placeholders in a string and allow the translate methods to take parameters. In this case, the example above would look something like this:

locale?.translate(‘between_values’, [minValue, maxValue]);

where the between_values is defined as

  "between_values" : "Should be between $0 and $1."

in the locale file.

Would this work. Or are there better options?