Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last updated date touched even if no fields changed (triggering sitemap updates) #1246

Closed
gbowne-quickbase opened this issue Feb 28, 2023 · 2 comments
Labels

Comments

@gbowne-quickbase
Copy link

Description

Even if no datapoints change in an entry, the last updated date is being set for each item when Feedme runs. The downstream effect of this is for users who have NYStudio107's SEOMatic plugin running sitemaps, since those will see a new date, generate an updated sitemap, and submit it to google. There's no new version created because there's nothing to update. Can we have it not update these if nothing changes?

(If authors are using this to determine the last time a feed ran, maybe this should be on the Feedme page itself?)

Steps to reproduce

  1. Run a feed where "Update items" is checked and items are properly keyed to allow for updates
  2. See the last updated change on imported items even if no data changed

Additional info

  • Craft version: 3.7.65.2
  • PHP version: 7.4.33
  • Database driver & version: MySQL 5.7.33
  • Plugins & versions: (relevant added)
    • Feedme 4.5.4
    • SEOMatic 3.4.49
@kristiansp
Copy link
Contributor

I don’t have a fix as such, but a question, what does the Feed Me logs say is updating? I have seen that if one of the fields effectively is an array (like entries field, etc), Feed Me doesn’t sort the arrays before comparing them, so two arrays with the same items can cause an update, because they have a different order.

I have a PR for this #735, it’s a simple fix, but will of course break on updates if you apply it.

@i-just
Copy link
Contributor

i-just commented Jun 20, 2023

Hi, thanks for getting in touch. I can’t replicate this behaviour.

Some improvements around checking if the values have changed have recently been made (v4.6.0 and v5.1.0).

I will close it now, but if you have a replicable scenario, please feel free to post the details, and we’ll look into it. A snippet of the feed and a screenshot of the mapping screen are always welcome, as they usually help reproduce the behaviour.

@i-just i-just closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants