Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO Verkle-Trie Database #65

Open
12 tasks
ControlCplusControlV opened this issue Dec 24, 2022 · 0 comments
Open
12 tasks

TODO Verkle-Trie Database #65

ControlCplusControlV opened this issue Dec 24, 2022 · 0 comments

Comments

@ControlCplusControlV
Copy link
Contributor

ControlCplusControlV commented Dec 24, 2022

database.rs

  • - We need a populate cache method that populates the cache from storage
  • - Think of a better name than ReadOnlyHigherDb, WriteOnlyHigherDb
  • - We could auto implement update methods which assert that there was a previous value they would just wrap the insert methods and check for None
  • - We can probably combine add_stem_as_branch_child and insert_branch into a single method called insert_branch_child
  • - Maybe we can return BranchChild, as the previous data could have been a stem or branch_meta then we can leave it upto the caller on how to deal with it on insert_branch
  • - Add a range query for the default database in verkle_db (x2)

default.rs

  • - Branch length check assumes that the cache is populated on startup from disk
  • - Get Stem Children from cache assumes that the cache is populated on startup from disk

memory_db

  • - Maybe change branch_table to use BChild and also include the index in the key (Vec, u8)
  • - get_branch_child could return the BranchChild instead and leave the caller to do what they want with it

meta.rs

  • - Explain where length check number comes from
  • - Use more accurate error msg when length check fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant