Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve database reconnect loop behavior when connectivity configuration is incorrect #73

Open
amotl opened this issue Dec 4, 2023 · 0 comments

Comments

@amotl
Copy link
Member

amotl commented Dec 4, 2023

Problem

At crate/cratedb-examples#174 (comment) ff, we discussed a problem that MLflow, when configured with an invalid database connection string, would still go into the reconnect loop, hogging it forever, because, well, it can't recover from a configuration error without further ado.

Suggestion

Improve the situation by either improving the reconnect loop itself, and/or by probing the database connection before actually starting the MLflow service/subsystem. If that fails, the daemon program should terminate.

Let's see how that fits into the other use case, when MLflow is embedded into the application itself, but it should work likewise, mainly preventing to go into the reconnect loop forever when it does not make any sense at all.

@amotl amotl changed the title Improve database connection loop Improve database reconnect loop behavior when connectivity configuration is incorrect Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant