-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API definition to follow protobuf conventions and best practices #110
Comments
Thanks @jdpedrie definitely worth considering |
Ah, that's a good idea. Did that in #111. I'm currently evaluating url frontier for use in a new project. We've used storm crawler in production for a number of years, but it's still a version from prior to the implementation of this project. Is the reference implementation suitable for production use? |
Great to hear you use StormCrawler! (even more curious about what you sue it for, scale etc...). What backend do you currently have with it?
|
We use it to power our news search feature in Freespoke. It's backed by elasticsearch. |
Hello,
I'd like to propose that in the next major version of this project, the API definition be modified to follow conventions for protocol buffers established in AIP and protolint.
Some of the changes I made:
google.protobuf.Empty
.UNSPECIFIED
. (https://google.aip.dev/126)google.protobuf.Timestamp
.Thanks for providing this API and the reference implementation!
A sample:
The text was updated successfully, but these errors were encountered: