From 5dc6ae44f260f89c1edc23eabedbfd29c0052f21 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Thu, 30 Jan 2025 18:56:38 +0100 Subject: [PATCH] MOBILE-4653 html: Adapt new control flow on core components Some changes left untouched because in implies type checking --- .../attachments/core-attachments.html | 58 +++++++------ .../bs-tooltip/core-bs-tooltip.html | 7 +- .../core-button-with-spinner.html | 13 +-- src/core/components/chart/core-chart.html | 16 ++-- .../components/combobox/core-combobox.html | 52 +++++++----- .../context-menu/context-menu-item.ts | 3 + .../core-context-menu-popover.html | 58 +++++++------ .../components/course-image/course-image.html | 11 ++- .../core-download-refresh.html | 42 ++++++---- .../core-dynamic-component.html | 4 +- .../components/empty-box/core-empty-box.html | 4 +- src/core/components/file/core-file.html | 65 ++++++++------ src/core/components/files/core-files.html | 33 +++++--- .../group-selector/group-selector.html | 32 ++++--- src/core/components/iframe/core-iframe.html | 61 ++++++++------ .../core-infinite-loading.html | 61 +++++++++----- .../input-errors/core-input-errors.html | 59 ++++++++----- src/core/components/loading/core-loading.html | 16 ++-- .../local-file/core-local-file.html | 84 +++++++++++-------- .../mark-required/core-mark-required.html | 4 +- src/core/components/message/message.html | 83 ++++++++++-------- src/core/components/mod-icon/mod-icon.html | 9 +- .../navigation-bar/core-navigation-bar.html | 34 ++++---- .../password-modal/password-modal.html | 8 +- .../progress-bar/core-progress-bar.html | 12 ++- .../components/recaptcha/core-recaptcha.html | 39 +++++---- .../show-password/core-show-password.html | 4 +- src/core/components/site-logo/site-logo.html | 41 ++++++--- .../site-picker/core-site-picker.html | 16 ++-- .../components/sites-list/sites-list.html | 75 ++++++++++------- .../components/swipe-slides/swipe-slides.html | 17 ++-- .../tabs-outlet/core-tabs-outlet.html | 43 ++++++---- .../components/tabs-outlet/tabs-outlet.ts | 24 ++++-- src/core/components/tabs/core-tabs.html | 62 ++++++++------ src/core/components/tabs/tab.ts | 2 +- src/core/components/timer/core-timer.html | 65 ++++++++------ .../user-avatar/core-user-avatar.html | 45 ++++++---- 37 files changed, 765 insertions(+), 497 deletions(-) diff --git a/src/core/components/attachments/core-attachments.html b/src/core/components/attachments/core-attachments.html index 5fa75df48c0..32b2f207478 100644 --- a/src/core/components/attachments/core-attachments.html +++ b/src/core/components/attachments/core-attachments.html @@ -3,15 +3,19 @@

{{ title }}

- - {{ 'core.maxsizeandattachments' | translate:{$a: {size: maxSizeReadable, attachments: maxSubmissionsReadable} } }} + + @if (maxSubmissionsReadable) { + {{ 'core.maxsizeandattachments' | translate:{$a: {size: maxSizeReadable, attachments: maxSubmissionsReadable} } }} + } @else { + {{ 'core.maxfilesize' | translate:{$a: maxSizeReadable} }} + } - {{ 'core.maxfilesize' | translate:{$a: maxSizeReadable} }}
- - + @if (unlimitedFiles || (maxSubmissions !== undefined && maxSubmissions >= 0 && files && files.length < maxSubmissions)) { + + + }
@if (fileTypes && fileTypes.mimetypes && fileTypes.mimetypes.length) { @@ -25,30 +29,36 @@ } - - - - - - - + @if (file.name) { + + + } @else { + + + } - - -

{{ 'core.fileuploader.nofilesattached' | translate }}

-
-
+ @if (!files || !files.length) { + + +

{{ 'core.fileuploader.nofilesattached' | translate }}

+
+
+ } diff --git a/src/core/components/bs-tooltip/core-bs-tooltip.html b/src/core/components/bs-tooltip/core-bs-tooltip.html index cc5e8e36cf0..ed8c13be770 100644 --- a/src/core/components/bs-tooltip/core-bs-tooltip.html +++ b/src/core/components/bs-tooltip/core-bs-tooltip.html @@ -1,6 +1,9 @@ -

-

{{content}}

+ @if (html) { +

+ } @else { +

{{content}}

+ }
diff --git a/src/core/components/button-with-spinner/core-button-with-spinner.html b/src/core/components/button-with-spinner/core-button-with-spinner.html index 7b4e27e2438..1ff53d98dee 100644 --- a/src/core/components/button-with-spinner/core-button-with-spinner.html +++ b/src/core/components/button-with-spinner/core-button-with-spinner.html @@ -1,6 +1,7 @@ -
- -
- - - +@if (loading) { + +} @else { +
+ +
+} diff --git a/src/core/components/chart/core-chart.html b/src/core/components/chart/core-chart.html index 95cdd8ed1e2..78dc4633464 100644 --- a/src/core/components/chart/core-chart.html +++ b/src/core/components/chart/core-chart.html @@ -1,8 +1,12 @@ - - - - +@if (chart) { + + @for (data of legendItems; track data.text) { + + + } + +} diff --git a/src/core/components/combobox/core-combobox.html b/src/core/components/combobox/core-combobox.html index 7b82ff63f64..8cc2c459f89 100644 --- a/src/core/components/combobox/core-combobox.html +++ b/src/core/components/combobox/core-combobox.html @@ -1,24 +1,34 @@ - -
- {{ label }} -
+@if (interface !== 'modal') { + +
+ @if (label) { + {{ label }} + } + @if (icon) { +
- -
+ +
+} @else { + + @if (icon) { + +} diff --git a/src/core/components/context-menu/context-menu-item.ts b/src/core/components/context-menu/context-menu-item.ts index 3008fc82d9b..5d68f452273 100644 --- a/src/core/components/context-menu/context-menu-item.ts +++ b/src/core/components/context-menu/context-menu-item.ts @@ -15,6 +15,7 @@ import { Component, Input, Output, OnInit, OnDestroy, EventEmitter, OnChanges, SimpleChange } from '@angular/core'; import { CoreContextMenuComponent } from '../context-menu/context-menu'; import { toBoolean } from '@/core/transforms/boolean'; +import { CoreUtils } from '@singletons/utils'; /** * This directive adds a item to the Context Menu popover. @@ -58,6 +59,8 @@ export class CoreContextMenuItemComponent implements OnInit, OnDestroy, OnChange @Output() onClosed?: EventEmitter<() => void>; // Will emit an event when the popover is closed because the item was clicked. @Output() toggleChange = new EventEmitter();// Will emit an event when toggle changes to enable 2-way data binding. + uniqueId = CoreUtils.getUniqueId('CoreContextMenuItem'); + protected hasAction = false; protected destroyed = false; diff --git a/src/core/components/context-menu/core-context-menu-popover.html b/src/core/components/context-menu/core-context-menu-popover.html index eda89d1e497..4bbb172ca63 100644 --- a/src/core/components/context-menu/core-context-menu-popover.html +++ b/src/core/components/context-menu/core-context-menu-popover.html @@ -1,28 +1,38 @@ - - -

{{ item.content }}

-
- - -

{{ item.content }}

-
- - -
- - {{item.badge}} - - {{ item.badgeA11yText | translate: {$a : item.badge } }} - - -
+ @for (item of items; track item.uniqueId) { + + @if (item.iconAction === 'toggle') { + +

{{ item.content }}

+
+ } @else { + +

{{ item.content }}

+
+ @if ((item.href || item.action) && item.iconAction) { + @if (item.iconAction === 'spinner') { + + } @else { +
+ }
diff --git a/src/core/components/course-image/course-image.html b/src/core/components/course-image/course-image.html index adc91885c63..6334d1509dd 100644 --- a/src/core/components/course-image/course-image.html +++ b/src/core/components/course-image/course-image.html @@ -1,4 +1,7 @@ -