Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QE] Negated label filters are not propagated correctly #4361

Open
albfan opened this issue Sep 20, 2024 · 6 comments
Open

[QE] Negated label filters are not propagated correctly #4361

albfan opened this issue Sep 20, 2024 · 6 comments

Comments

@albfan
Copy link

albfan commented Sep 20, 2024

General information

  • OS: Linux
  • Hypervisor: KVM
  • Did you run crc setup before starting it (Yes/No)? Yes
  • Running CRC on: Laptop

Steps to reproduce

  1. Use negated label filters "! microshift-preset"
  2. qe step on pipelinerun fails

Expected

Test for non matching label filters

Actual

Test suite fails

@albfan albfan added kind/bug Something isn't working status/need triage labels Sep 20, 2024
@albfan
Copy link
Author

albfan commented Sep 20, 2024

Probably a better option would be to run explicitly test (label microshift-preset, openshift-preset) to be prepared for a new bundle.

test what "is not something" might match non expected test

CC @lilyLuLiu @adrianriobo

@praveenkumar praveenkumar changed the title Negated label filters are not propagated correctly [QE] Negated label filters are not propagated correctly Sep 20, 2024
@adrianriobo
Copy link
Contributor

Yeah it is fine to me, in any case this is inline with fixing the issue also in case we actively need to set negation.

Fixing this will fix it across our framework, so even if we now move to use explicit, this will solve a problem for us in the future in case we need negation.

@albfan
Copy link
Author

albfan commented Sep 26, 2024

This will be automatized with #4369

@albfan albfan closed this as completed Sep 26, 2024
@lilyLuLiu lilyLuLiu reopened this Sep 29, 2024
@lilyLuLiu
Copy link
Contributor

@albfan, Hi, This issue has been fixed for windows and Linux, but still failed on macOS.

@albfan
Copy link
Author

albfan commented Sep 30, 2024

Looks related with extra step to execute deliverest on mac

@albfan
Copy link
Author

albfan commented Oct 2, 2024

PR #4383 should resolve for mac too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants