Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiling on armv7 #22

Open
iamdey opened this issue Mar 7, 2025 · 1 comment
Open

compiling on armv7 #22

iamdey opened this issue Mar 7, 2025 · 1 comment

Comments

@iamdey
Copy link

iamdey commented Mar 7, 2025

cf. https://github.com/crill-dev/crill/blob/main/include/crill/progressive_backoff_wait.h#L43

void progressive_backoff_wait(Predicate&& pred)
{
  #if CRILL_INTEL
    impl::progressive_backoff_wait_intel<5, 10, 3000>(std::forward<Predicate>(pred));
    // approx. 5x5 ns (= 25 ns), 10x40 ns (= 400 ns), and 3000x350 ns (~ 1 ms),
    // respectively, when measured on a 2.9 GHz Intel i9
  #elif CRILL_ARM_64BIT
    impl::progressive_backoff_wait_armv8<2, 750>(std::forward<Predicate>(pred));
    // approx. 2x10 ns (= 20 ns) and 750x1333 ns (~ 1 ms), respectively, on an
    // Apple Silicon Mac or an armv8 based phone.
  #else
    #error "Platform not supported!"
  #endif
}

I'm a very beginner on C++ etc. what could be done to have it working (or at least compiling) on armv7 ?

For now, I comment the erroneous line when I compile for armv7 since the method isn't called at all:

-     #error "Platform not supported!"
+    // #error "Platform not supported!"
@triplef
Copy link

triplef commented Mar 10, 2025

PR #21 has a solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants