From b1433ab321202af4d396a304aa4b14b2ad3cc567 Mon Sep 17 00:00:00 2001 From: Andrii Bodnar Date: Thu, 6 Feb 2025 13:14:49 +0200 Subject: [PATCH] Apply suggestions from code review --- Sources/CrowdinSDK/CrowdinFileSystem/File.swift | 1 - .../ETagStorage/FileEtagStorage.swift | 6 ------ 2 files changed, 7 deletions(-) diff --git a/Sources/CrowdinSDK/CrowdinFileSystem/File.swift b/Sources/CrowdinSDK/CrowdinFileSystem/File.swift index 0c9d1956..20d01db4 100644 --- a/Sources/CrowdinSDK/CrowdinFileSystem/File.swift +++ b/Sources/CrowdinSDK/CrowdinFileSystem/File.swift @@ -84,7 +84,6 @@ class ReadWriteFile: File { guard let file = self.file else { return } file.write(to: self.path) } - func read() { self.file = T.read(from: self.path) } diff --git a/Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/ETagStorage/FileEtagStorage.swift b/Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/ETagStorage/FileEtagStorage.swift index 59a7660d..15494475 100644 --- a/Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/ETagStorage/FileEtagStorage.swift +++ b/Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/ETagStorage/FileEtagStorage.swift @@ -17,7 +17,6 @@ final class FileEtagStorage: AnyEtagStorage { dictionaryFile.read() return (dictionaryFile.file as? [String: [String: String]]) ?? [:] } - init(localization: String) { self.localization = localization let path = CrowdinFolder.shared.path + "/" + FileEtagStorage.fileName @@ -26,7 +25,6 @@ final class FileEtagStorage: AnyEtagStorage { dictionaryFile.create() } } - func save(etag: String?, for file: String) { queue.sync { var currentEtags = getEtags() @@ -37,14 +35,12 @@ final class FileEtagStorage: AnyEtagStorage { try? self.dictionaryFile.save() } } - func etag(for file: String) -> String? { queue.sync { let currentEtags = getEtags() return currentEtags[localization]?[file] } } - func clear() { queue.sync { var currentEtags = getEtags() @@ -53,7 +49,6 @@ final class FileEtagStorage: AnyEtagStorage { try? self.dictionaryFile.save() } } - func clear(for file: String) { queue.sync { var currentEtags = getEtags() @@ -64,7 +59,6 @@ final class FileEtagStorage: AnyEtagStorage { try? self.dictionaryFile.save() } } - /// Remove file static func clear() { let path = CrowdinFolder.shared.path + "/" + FileEtagStorage.fileName