diff --git a/pkg/cwhub/itemupgrade.go b/pkg/cwhub/itemupgrade.go index b9958bea873..073bd87978c 100644 --- a/pkg/cwhub/itemupgrade.go +++ b/pkg/cwhub/itemupgrade.go @@ -101,7 +101,7 @@ func (i *Item) downloadLatest(overwrite bool, updateOnly bool) (string, error) { } } - if !i.State.Installed && updateOnly && i.State.Downloaded { + if !i.State.Installed && updateOnly && i.State.Downloaded && !overwrite { i.hub.logger.Debugf("skipping upgrade of %s: not installed", i.Name) return "", nil } diff --git a/test/bats/20_hub_items.bats b/test/bats/20_hub_items.bats index 171e4b8b1f5..72e09dfa268 100644 --- a/test/bats/20_hub_items.bats +++ b/test/bats/20_hub_items.bats @@ -181,3 +181,15 @@ teardown() { rune -0 jq '.collections' <(output) assert_json '[]' } + +@test "tainted hub file, not enabled, install --force should repair" { + rune -0 cscli scenarios install crowdsecurity/ssh-bf + rune -0 cscli scenarios inspect crowdsecurity/ssh-bf -o json + local_path="$(jq -r '.local_path' <(output))" + echo >> "$local_path" + rm "$local_path" + rune -0 cscli scenarios install crowdsecurity/ssh-bf --force + rune -0 cscli scenarios inspect crowdsecurity/ssh-bf -o json + rune -0 jq -c '.tainted' <(output) + assert_output 'false' +}