Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Investigate what PF stylesheets are provided by each version of the Console #128

Open
aptmac opened this issue Feb 5, 2025 · 1 comment

Comments

@aptmac
Copy link
Member

aptmac commented Feb 5, 2025

Issue #125 was concerned with missing description-list styling for the Topology page, and we had #101 track missing overflow-menu styling in the Recordings page.

In both of these cases, the required PF stylesheets were missing when running in CRC at 4.17, but looked to be okay when using 4.19.

PR #126 added imports for the missing stylesheets so they would be present in all console versions, but it is worthwhile investigating why this is the case.

A potential cause could be the supported PF versions for different versions of the console. The table here shows that up until 4.19 the console supports both PF 4 and 5, whereas 4.19 supports only 5. This will be important to track and understand going forward as I already see the commits to update to PF6.

@tthvo
Copy link
Member

tthvo commented Feb 5, 2025

I happen to have a 4.18 OpenShift at the moment and have the plugin installed. The topology panel looks OK (i.e. without the latest commit for css fix).

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants