Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle race conditions #15

Closed
overheadhunter opened this issue Jun 14, 2018 · 1 comment
Closed

handle race conditions #15

overheadhunter opened this issue Jun 14, 2018 · 1 comment
Assignees
@overheadhunter
Milestone
1.0.0

Comments

@overheadhunter
Copy link
Member

We should internally use a ReadWriteLock to sync access per path (potentially including child paths). Until then we will use the -s mount option.

On Macs we can easily create such race conditions by copying a (nonempty) directory onto the mounted volume when not using -onoappledouble.

(not to be confused with #13)
@overheadhunter overheadhunter self-assigned this Sep 9, 2018
@overheadhunter overheadhunter mentioned this issue Sep 9, 2018
Open
overheadhunter added a commit that referenced this issue Sep 11, 2018
@overheadhunter
updated LockManager, now only using one map for pathLocks (preparatio…
3ee4e5b 
…n for #15)
overheadhunter added a commit that referenced this issue Sep 11, 2018
@overheadhunter
Added DataLocks (preparation for #15)
df5686b
overheadhunter added a commit that referenced this issue Sep 11, 2018
@overheadhunter
locking access, thus osxfuse no longer required to run single-threade…
870c0c2 
…d (see #15, needs testing)
overheadhunter added a commit that referenced this issue Sep 12, 2018
@overheadhunter
replaced ConcurrentMap by Guava's weak-valued Cache (references #15) …
26390bf 
…TODO: implement DataLocks
overheadhunter added a commit that referenced this issue Sep 12, 2018
@overheadhunter
Implemented DataLocks (#15)
4639018
@overheadhunter overheadhunter added this to the 1.0.0 milestone Sep 20, 2018
@overheadhunter
Copy link
Member Author

Locking scheme is implemented in a best-effort manner. We have disabled -s and I haven't seen any errors that clearly lead to the assumption that race conditions still occur.

Reopen if needed.

@overheadhunter overheadhunter mentioned this issue Mar 25, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@overheadhunter overheadhunter

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@overheadhunter