Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock Popup doesn't appear immediately when trying to unlock a vault #336

Open
2 tasks done
NovaliX-Dev opened this issue Feb 6, 2024 · 4 comments
Open
2 tasks done
Labels
type:upstream-bug Something isn't working in upstream

Comments

@NovaliX-Dev
Copy link

NovaliX-Dev commented Feb 6, 2024

Please agree to the following

Summary

When i try to unlock my vault, the unlock popup doesn't show up immediately, instead waiting 2-3 seconds (can vary) before showing up.

From what i remember, before the popup was not appearing at all. Re-adding the vault into Cryptomator made the issue less severe.

System Setup

  • iOS: 17.3
  • Cryptomator: 2.5.0

Cloud Type

OneDrive

Steps to Reproduce

  1. If it's not locked already, lock your vault
  2. Try to open your vault in the File app

Expected Behavior

The unlock pop-up should appear immediately.

Actual Behavior

It seems it waits 2-3 seconds before showing up.

Reproducibility

Always

Relevant Log Output

No response

Anything else?

RPReplay_Final1707144895.mp4
@NovaliX-Dev NovaliX-Dev added the type:bug Something isn't working label Feb 6, 2024
@NovaliX-Dev NovaliX-Dev changed the title Unlock Pop up doesn't appear immediately Unlock Popup doesn't appear immediately Feb 6, 2024
@NovaliX-Dev NovaliX-Dev changed the title Unlock Popup doesn't appear immediately Unlock Popup doesn't appear immediately in the File app Feb 6, 2024
@NovaliX-Dev NovaliX-Dev changed the title Unlock Popup doesn't appear immediately in the File app Unlock Popup doesn't appear immediately when trying to unlock a vault Feb 6, 2024
@phil1995
Copy link
Collaborator

Hi @NovaliX-Dev
thanks for reporting. Unfortunately there isn't much we can do here since we trigger this screen immediately but there is a slight delay coming from iOS since the unlock screen is a separate extension (FileProviderExtensionUI) and we can't really control how fast Apple wants to show it to the user. We would also like to have it visible immediately since the vault is already locked. But note that you also can't interact with the items you see for 1-2s in your locked vault.

@NovaliX-Dev
Copy link
Author

Hi @phil1995 ,
Thank you for the explanation.

I have one question thought. There are other case where we see custom "pop-ups" (not sure it's the right name) showing up from apps : when using auto-fill from password managers on websites(eg Bitwarden) when sharing files with apps (eg Signal), etc.

I've tested the pop-ups with those apps and their showing animations is flawless. That's why I'm thinking there is a bug in the Cryptomator app code.

Are these pop-ups the same kind as the pop-up Cryptomator use ? That would be logical to me, but it's worth asking.

@iammajid
Copy link
Contributor

iammajid commented Nov 6, 2024

Hi @NovaliX-Dev,

Apps like Bitwarden and Signal use system extensions such as AutoFill and Share extensions, which are optimized by iOS for immediate display and minimal initialization. These extensions are designed for quick tasks and have less overhead.

Cryptomator's unlock prompt uses the File Provider Extension UI to integrate securely with the iOS Files app. This extension handles encrypted files and requires a bit more initialization time to establish a secure environment, which can lead to the slight delay you're experiencing.

We acknowledge that this isn't ideal and agree there's room for optimization. We're actively exploring ways to improve the performance, but due to the nature of the File Provider Extension, we haven't found a way to reduce the delay yet.

@iammajid iammajid added type:upstream-bug Something isn't working in upstream and removed type:bug Something isn't working labels Nov 6, 2024
@NovaliX-Dev
Copy link
Author

Hi @iammajid, thank you for explanation.

I hope you will find a way soon 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:upstream-bug Something isn't working in upstream
Projects
None yet
Development

No branches or pull requests

3 participants