From 36cd2481c23adfd1a2c43247605223df3fb415ec Mon Sep 17 00:00:00 2001
From: Quinton Miller <nicetas.c@gmail.com>
Date: Tue, 3 Sep 2024 23:29:16 +0800
Subject: [PATCH] `#read_timeout=`, `#write_timeout=`, `#connect_timeout=`

---
 spec/std/http/client/client_spec.cr | 6 +++---
 spec/std/http/server/server_spec.cr | 2 +-
 spec/std/io/io_spec.cr              | 4 ++--
 spec/std/socket/socket_spec.cr      | 2 +-
 spec/std/socket/unix_socket_spec.cr | 4 ++--
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/spec/std/http/client/client_spec.cr b/spec/std/http/client/client_spec.cr
index 4c9da8db7ad7..bf5697b846b3 100644
--- a/spec/std/http/client/client_spec.cr
+++ b/spec/std/http/client/client_spec.cr
@@ -351,7 +351,7 @@ module HTTP
       test_server("localhost", 0, 0.5, write_response: false) do |server|
         client = Client.new("localhost", server.local_address.port)
         expect_raises(IO::TimeoutError, {% if flag?(:win32) %} "WSARecv timed out" {% else %} "Read timed out" {% end %}) do
-          client.read_timeout = 0.001
+          client.read_timeout = 1.millisecond
           client.get("/?sleep=1")
         end
       end
@@ -365,7 +365,7 @@ module HTTP
       test_server("localhost", 0, 0, write_response: false) do |server|
         client = Client.new("localhost", server.local_address.port)
         expect_raises(IO::TimeoutError, {% if flag?(:win32) %} "WSASend timed out" {% else %} "Write timed out" {% end %}) do
-          client.write_timeout = 0.001
+          client.write_timeout = 1.millisecond
           client.post("/", body: "a" * 5_000_000)
         end
       end
@@ -374,7 +374,7 @@ module HTTP
     it "tests connect_timeout" do
       test_server("localhost", 0, 0) do |server|
         client = Client.new("localhost", server.local_address.port)
-        client.connect_timeout = 0.5
+        client.connect_timeout = 0.5.seconds
         client.get("/")
       end
     end
diff --git a/spec/std/http/server/server_spec.cr b/spec/std/http/server/server_spec.cr
index c8b39c9e7e42..ede2226050de 100644
--- a/spec/std/http/server/server_spec.cr
+++ b/spec/std/http/server/server_spec.cr
@@ -427,7 +427,7 @@ describe HTTP::Server do
       begin
         ch.receive
         client = HTTP::Client.new(address.address, address.port, client_context)
-        client.read_timeout = client.connect_timeout = 3
+        client.read_timeout = client.connect_timeout = 3.seconds
         client.get("/").body.should eq "ok"
       ensure
         ch.send nil
diff --git a/spec/std/io/io_spec.cr b/spec/std/io/io_spec.cr
index 6974a9fe3466..924a5f8c157d 100644
--- a/spec/std/io/io_spec.cr
+++ b/spec/std/io/io_spec.cr
@@ -105,11 +105,11 @@ describe IO do
         write.puts "hello"
         slice = Bytes.new 1024
 
-        read.read_timeout = 1
+        read.read_timeout = 1.second
         read.read(slice).should eq(6)
 
         expect_raises(IO::TimeoutError) do
-          read.read_timeout = 0.0000001
+          read.read_timeout = 0.1.microseconds
           read.read(slice)
         end
       end
diff --git a/spec/std/socket/socket_spec.cr b/spec/std/socket/socket_spec.cr
index 2127e196b746..de1c140bda37 100644
--- a/spec/std/socket/socket_spec.cr
+++ b/spec/std/socket/socket_spec.cr
@@ -73,7 +73,7 @@ describe Socket, tags: "network" do
     server = Socket.new(Socket::Family::INET, Socket::Type::STREAM, Socket::Protocol::TCP)
     port = unused_local_port
     server.bind("0.0.0.0", port)
-    server.read_timeout = 0.1
+    server.read_timeout = 0.1.seconds
     server.listen
 
     expect_raises(IO::TimeoutError) { server.accept }
diff --git a/spec/std/socket/unix_socket_spec.cr b/spec/std/socket/unix_socket_spec.cr
index 24777bada67f..602fc57a3ce8 100644
--- a/spec/std/socket/unix_socket_spec.cr
+++ b/spec/std/socket/unix_socket_spec.cr
@@ -76,8 +76,8 @@ describe UNIXSocket do
     it "tests read and write timeouts" do
       UNIXSocket.pair do |left, right|
         # BUG: shrink the socket buffers first
-        left.write_timeout = 0.0001
-        right.read_timeout = 0.0001
+        left.write_timeout = 0.1.milliseconds
+        right.read_timeout = 0.1.milliseconds
         buf = ("a" * IO::DEFAULT_BUFFER_SIZE).to_slice
 
         expect_raises(IO::TimeoutError, "Write timed out") do