From 73263a8f1ab0f5662dd4974420e8e8d5ab7ae989 Mon Sep 17 00:00:00 2001
From: Quinton Miller <nicetas.c@gmail.com>
Date: Wed, 4 Sep 2024 16:00:52 +0800
Subject: [PATCH] Support non-blocking `Process.run` standard streams on
 Windows (#14941)

---
 spec/std/process_spec.cr | 14 +++++++++
 src/process.cr           | 67 +++++++++++++++++++++++-----------------
 2 files changed, 53 insertions(+), 28 deletions(-)

diff --git a/spec/std/process_spec.cr b/spec/std/process_spec.cr
index f067d2f5c775..57f90121c26b 100644
--- a/spec/std/process_spec.cr
+++ b/spec/std/process_spec.cr
@@ -189,6 +189,20 @@ pending_interpreted describe: Process do
       Process.run(*stdin_to_stdout_command, error: closed_io)
     end
 
+    it "forwards non-blocking file" do
+      with_tempfile("non-blocking-process-input.txt", "non-blocking-process-output.txt") do |in_path, out_path|
+        File.open(in_path, "w+", blocking: false) do |input|
+          File.open(out_path, "w+", blocking: false) do |output|
+            input.puts "hello"
+            input.rewind
+            Process.run(*stdin_to_stdout_command, input: input, output: output)
+            output.rewind
+            output.gets_to_end.chomp.should eq("hello")
+          end
+        end
+      end
+    end
+
     it "sets working directory with string" do
       parent = File.dirname(Dir.current)
       command = {% if flag?(:win32) %}
diff --git a/src/process.cr b/src/process.cr
index c8364196373f..63b78bf0f716 100644
--- a/src/process.cr
+++ b/src/process.cr
@@ -291,33 +291,20 @@ class Process
 
   private def stdio_to_fd(stdio : Stdio, for dst_io : IO::FileDescriptor) : IO::FileDescriptor
     case stdio
-    when IO::FileDescriptor
-      stdio
-    when IO
-      if stdio.closed?
-        if dst_io == STDIN
-          return File.open(File::NULL, "r").tap(&.close)
-        else
-          return File.open(File::NULL, "w").tap(&.close)
+    in IO::FileDescriptor
+      # on Windows, only async pipes can be passed to child processes, async
+      # regular files will report an error and those require a separate pipe
+      # (https://github.com/crystal-lang/crystal/pull/13362#issuecomment-1519082712)
+      {% if flag?(:win32) %}
+        unless stdio.blocking || stdio.info.type.pipe?
+          return io_to_fd(stdio, for: dst_io)
         end
-      end
-
-      if dst_io == STDIN
-        fork_io, process_io = IO.pipe(read_blocking: true)
-
-        @wait_count += 1
-        ensure_channel
-        spawn { copy_io(stdio, process_io, channel, close_dst: true) }
-      else
-        process_io, fork_io = IO.pipe(write_blocking: true)
+      {% end %}
 
-        @wait_count += 1
-        ensure_channel
-        spawn { copy_io(process_io, stdio, channel, close_src: true) }
-      end
-
-      fork_io
-    when Redirect::Pipe
+      stdio
+    in IO
+      io_to_fd(stdio, for: dst_io)
+    in Redirect::Pipe
       case dst_io
       when STDIN
         fork_io, @input = IO.pipe(read_blocking: true)
@@ -330,17 +317,41 @@ class Process
       end
 
       fork_io
-    when Redirect::Inherit
+    in Redirect::Inherit
       dst_io
-    when Redirect::Close
+    in Redirect::Close
       if dst_io == STDIN
         File.open(File::NULL, "r")
       else
         File.open(File::NULL, "w")
       end
+    end
+  end
+
+  private def io_to_fd(stdio : Stdio, for dst_io : IO::FileDescriptor) : IO::FileDescriptor
+    if stdio.closed?
+      if dst_io == STDIN
+        return File.open(File::NULL, "r").tap(&.close)
+      else
+        return File.open(File::NULL, "w").tap(&.close)
+      end
+    end
+
+    if dst_io == STDIN
+      fork_io, process_io = IO.pipe(read_blocking: true)
+
+      @wait_count += 1
+      ensure_channel
+      spawn { copy_io(stdio, process_io, channel, close_dst: true) }
     else
-      raise "BUG: Impossible type in stdio #{stdio.class}"
+      process_io, fork_io = IO.pipe(write_blocking: true)
+
+      @wait_count += 1
+      ensure_channel
+      spawn { copy_io(process_io, stdio, channel, close_src: true) }
     end
+
+    fork_io
   end
 
   # :nodoc: