Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch conversion #13

Open
10 of 15 tasks
mvsjober opened this issue Oct 25, 2023 · 3 comments
Open
10 of 15 tasks

PyTorch conversion #13

mvsjober opened this issue Oct 25, 2023 · 3 comments

Comments

@mvsjober
Copy link
Member

mvsjober commented Oct 25, 2023

  • [EASY] Exercise 1: 01-tf2-test-setup.ipynb
  • [YES, DOUBLE CHECK] Exercise 2: 02-tf2-mnist-mlp.ipynb -> pytorch-mnist-mlp.ipynb
  • [EASY] Exercise 3: 03-tf2-mnist-cnn.ipynb
  • [NON-TRIVIAL] Exercise 4: 04-tf2-imdb-rnn.ipynb
  • [YES, DOUBLE CHECK] Exercise 5: Task 1 & 2 (yes, except BiT and TFRecord ones)
  • [YES, DOUBLE CHECK] Exercise 5 / Extracurricular 4: ViT
  • [NON-TRIVIAL] Exercise 6 (diff models)
  • [YES, DOUBLE CHECK] Exercise 7 (20ng, rnn, cnn, bert)
  • [NON-TRIVIAL] Exercise 8 (aclImdb-gpt)
  • [EASY] Exercise 9 (multi-gpu and Horovod) -> multi-gpu and DDP

Notes of things still to do:

  • Need to add pytorch_test.py
  • check day2 pytorch scripts that style is similar to day1 (use Sequential style for simple, check training and testing loops)
  • pytorch VIT is basically broken, needs to be looked at
  • 20ng scripts OK, but RNN (71% vs 85%) and CNN (73% vs 94%) have worse accuracy results
  • Try find something similiar to aclImdb-gpt but for PyTorch
@jmakoske
Copy link
Member

Some modern CNN, not necessarily BiT, could be nice to show that CNNs can compete

@mvsjober
Copy link
Member Author

Do we still keep the show_failures and confusion matrices and things in the mnist-mlp?

@jmakoske
Copy link
Member

Do we still keep the show_failures and confusion matrices and things in the mnist-mlp?

Maybe not, or move those to an "optional" subsection or something, as there are more things to introduce in the pytorch code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants