Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReserveManager Failing #789

Open
robinhood1596 opened this issue Apr 1, 2023 · 0 comments
Open

ReserveManager Failing #789

robinhood1596 opened this issue Apr 1, 2023 · 0 comments
Labels
Bug Something isn't working. Reproducible This issue is reproducible.

Comments

@robinhood1596
Copy link

Non-Vanilla Bug Report

Describe the bug

Pawns don't do job because it's reserved by another pawn that can't do the jobs (e.g. because of restrictions).
Pawns that can do the job don't do it because it's reserved by antoher pawn that won't do it and is currently doing something else.

E.g
Grant should smelt, job reserved by Alica
Alica won't smelt because job is reserved by Hugh
Hugh can't smelt because job is reserved by Todd
Todd can't smelt because job is reserved by Lifter 1 (which can't smelt)

Steps to reproduce the behavior (VERY IMPORTANT)

  1. Make a normal colony with several jobs.
  2. Have like 12+ pawns
  3. wait and try to manually assign jobs at some point (or see if jobs get done or not)

Error Logs ?

!!! You can copy paste an error here !!!

HugsLib log

(Can't upload for some reason)

Object with load ID Job_4618344 is referenced (xml node name: job) but is not deep-saved. This will cause errors during loading.
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Warning (string)
Verse.DebugLoadIDsSavingErrorsChecker:CheckForErrorsAndClear ()
Verse.ScribeSaver:FinalizeSaving ()
Verse.SafeSaver:DoSave (string,string,System.Action)
Verse.SafeSaver:Save (string,string,System.Action,bool)
Verse.GameDataSaveLoader:SaveGame (string)
RimWorld.Dialog_SaveFileList_Save/<>c__DisplayClass3_0:<DoFileInteraction>b__0 ()
Verse.LongEventHandler:UpdateCurrentSynchronousEvent (bool&)
Verse.LongEventHandler:LongEventsUpdate (bool&)
(wrapper dynamic-method) Verse.Root:Verse.Root.Update_Patch1 (Verse.Root)
(wrapper dynamic-method) Verse.Root_Play:Verse.Root_Play.Update_Patch1 (Verse.Root_Play)

ReservationManager.Reserve cannot reserve. This is likely because reservation is no longer valid after CanReserve was called due to time delay with multiple threads.
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Warning (string)
RimThreaded.RW_Patches.ReservationManager_Patch:Reserve (Verse.AI.ReservationManager,bool&,Verse.Pawn,Verse.AI.Job,Verse.LocalTargetInfo,int,int,Verse.ReservationLayerDef,bool)
(wrapper dynamic-method) Verse.AI.ReservationManager:Verse.AI.ReservationManager.Reserve_Patch2 (Verse.AI.ReservationManager,Verse.Pawn,Verse.AI.Job,Verse.LocalTargetInfo,int,int,Verse.ReservationLayerDef,bool)
Verse.AI.ReservationUtility:Reserve (Verse.Pawn,Verse.LocalTargetInfo,Verse.AI.Job,int,int,Verse.ReservationLayerDef,bool)
CommonSense.JobDriver_DoBill_MakeNewToils_CommonSensePatch/<>c__DisplayClass1_1:<DoMakeToils>b__9 ()
Verse.AI.JobDriver:TryActuallyStartNextToil ()
Verse.AI.JobDriver:ReadyForNextToil ()
Verse.AI.JobDriver:JumpToToil (Verse.AI.Toil)
Verse.AI.Toils_Jump/<>c__DisplayClass1_0:<JumpIf>b__0 ()
Verse.AI.JobDriver:TryActuallyStartNextToil ()
Verse.AI.JobDriver:ReadyForNextToil ()
Verse.AI.JobDriver:TryActuallyStartNextToil ()
Verse.AI.JobDriver:ReadyForNextToil ()
Verse.AI.JobDriver:DriverTick ()
Verse.AI.Pawn_JobTracker:JobTrackerTick ()
Verse.Pawn:Tick ()
RimThreaded.RW_Patches.TickList_Patch:NormalThingTick ()
RimThreaded.RimThreaded:ExecuteTicks ()
RimThreaded.RimThreaded:ProcessTicks (RimThreaded.RimThreaded/ThreadInfo)
RimThreaded.RimThreaded:InitializeThread (object)
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart (object)


Reservation manager failed to clean up properly; Megascarab36982 still reserving Thing_VFE_TableStonecutterElectric482069
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) Verse.Log:Verse.Log.Error_Patch1 (string)
Verse.Log:ErrorOnce (string,int)
RimThreaded.RW_Patches.Pawn_Patch:VerifyReservations (Verse.Pawn)
(wrapper dynamic-method) Verse.Pawn:Verse.Pawn.VerifyReservations_Patch1 (Verse.Pawn)
(wrapper dynamic-method) Verse.AI.Pawn_JobTracker:Verse.AI.Pawn_JobTracker.CleanupCurrentJob_Patch0 (Verse.AI.Pawn_JobTracker,Verse.AI.JobCondition,bool,bool,bool,System.Nullable`1<bool>)
(wrapper dynamic-method) Verse.AI.Pawn_JobTracker:Verse.AI.Pawn_JobTracker.EndCurrentJob_Patch3 (Verse.AI.Pawn_JobTracker,Verse.AI.JobCondition,bool,bool)
Verse.AI.JobDriver:EndJobWith (Verse.AI.JobCondition)
Verse.AI.JobDriver:TryActuallyStartNextToil ()
Verse.AI.JobDriver:ReadyForNextToil ()
Verse.AI.JobDriver:TryActuallyStartNextToil ()
Verse.AI.JobDriver:ReadyForNextToil ()
Verse.AI.JobDriver:TryActuallyStartNextToil ()
Verse.AI.JobDriver:ReadyForNextToil ()
Verse.AI.JobDriver:DriverTick ()
Verse.AI.Pawn_JobTracker:JobTrackerTick ()
Verse.Pawn:Tick ()
RimThreaded.RW_Patches.TickList_Patch:NormalThingTick ()
RimThreaded.RimThreaded:ExecuteTicks ()
RimThreaded.RimThreaded:ProcessTicks (RimThreaded.RimThreaded/ThreadInfo)
RimThreaded.RimThreaded:InitializeThread (object)
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart (object)

Player.log (Optional)

Player.log

Save file

(can't add for some reason, contact me if you want and i can send directly?)

Screenshots (Optional) ?

grafik

Mod list (Preferably a RimPy compatible list.)

❗❗❗ Add RimPy mod list here ❗❗❗ 

[Mod list length: 53]
Harmony [https://steamcommunity.com/sharedfiles/filedetails/?id=2009463077]
Core [https:// no link (local mod)]
Royalty [Official DLC] [https:// no link (local mod)]
Ideology [Official DLC] [https:// no link (local mod)]
Biotech [Official DLC] [https:// no link (local mod)]
HugsLib [https://steamcommunity.com/sharedfiles/filedetails/?id=818773962]
Achtung! [https://steamcommunity.com/sharedfiles/filedetails/?id=730936602]
Advanced Moisture Pump [1.4] [https://steamcommunity.com/sharedfiles/filedetails/?id=2880970348]
Allow Tool [https://steamcommunity.com/sharedfiles/filedetails/?id=761421485]
Auto-Cut Blight [https://steamcommunity.com/sharedfiles/filedetails/?id=1885186534]
Better Pawn Control [https://steamcommunity.com/sharedfiles/filedetails/?id=1541460369]
BetterInfoCard [https://steamcommunity.com/sharedfiles/filedetails/?id=2890920739]
Biotech Expansion - Core [https://steamcommunity.com/sharedfiles/filedetails/?id=2884018485]
Biotech Expansion - Mammalia [https://steamcommunity.com/sharedfiles/filedetails/?id=2878084431]
Biotech Expansion - Mythic [https://steamcommunity.com/sharedfiles/filedetails/?id=2883216840]
Blueprints [https://steamcommunity.com/sharedfiles/filedetails/?id=708455313]
CleaningArea [https://steamcommunity.com/sharedfiles/filedetails/?id=870089952]
Common Sense [https://steamcommunity.com/sharedfiles/filedetails/?id=1561769193]
Dubs Mint Menus [https://steamcommunity.com/sharedfiles/filedetails/?id=1446523594]
Easy Speedup [https://steamcommunity.com/sharedfiles/filedetails/?id=1132557840]
Enhanced Vat Learning [https://steamcommunity.com/sharedfiles/filedetails/?id=2908453851]
FindAGunDamnIt! (Continued) [https://steamcommunity.com/sharedfiles/filedetails/?id=2089553836]
Vanilla Expanded Framework [https://steamcommunity.com/sharedfiles/filedetails/?id=2023507013]
Firefoam Things [https://steamcommunity.com/sharedfiles/filedetails/?id=2885014197]
Gene Ripper [https://steamcommunity.com/sharedfiles/filedetails/?id=2885485814]
Gene Trader [https://steamcommunity.com/sharedfiles/filedetails/?id=2886375137]
Incident Tweaker [https://steamcommunity.com/sharedfiles/filedetails/?id=2051895989]
Loading In Progress [https://steamcommunity.com/sharedfiles/filedetails/?id=1975622772]
Numbers [https://steamcommunity.com/sharedfiles/filedetails/?id=1414302321]
Planning Extended [https://steamcommunity.com/sharedfiles/filedetails/?id=2877392159]
Vanilla Furniture Expanded - Security [https://steamcommunity.com/sharedfiles/filedetails/?id=1845154007]
Reinforced Walls+ [https://steamcommunity.com/sharedfiles/filedetails/?id=2882167814]
Replace Stuff [https://steamcommunity.com/sharedfiles/filedetails/?id=1372003680]
Research Whatever [https://steamcommunity.com/sharedfiles/filedetails/?id=2552092060]
RimPy Mod Manager Database [https://steamcommunity.com/sharedfiles/filedetails/?id=1847679158]
Scheduled Events (Continued) [https://steamcommunity.com/sharedfiles/filedetails/?id=2126125070]
Smarter Construction [https://steamcommunity.com/sharedfiles/filedetails/?id=2202185773]
Stack XXL [https://steamcommunity.com/sharedfiles/filedetails/?id=826366050]
Vanilla Furniture Expanded - Power [https://steamcommunity.com/sharedfiles/filedetails/?id=2062943477]
Vanilla Furniture Expanded - Production [https://steamcommunity.com/sharedfiles/filedetails/?id=1880253632]
Vanilla Furniture Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=1718190143]
Vanilla Furniture Expanded - Spacer Module [https://steamcommunity.com/sharedfiles/filedetails/?id=2028381079]
Vanilla Genetics Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=2801160906]
Vanilla Outposts Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=2688941031]
Vanilla Outposts Expanded: Additional Outposts [https://steamcommunity.com/sharedfiles/filedetails/?id=2873841790]
Vanilla Trading Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=2785616901]
Wall Light [https://steamcommunity.com/sharedfiles/filedetails/?id=1423699208]
XML Extensions [https://steamcommunity.com/sharedfiles/filedetails/?id=2574315206]
Walls are solid [https://steamcommunity.com/sharedfiles/filedetails/?id=2896548513]
LWM's Deep Storage [https://steamcommunity.com/sharedfiles/filedetails/?id=1617282896]
Pick Up And Haul [https://steamcommunity.com/sharedfiles/filedetails/?id=1279012058]
While You're Up / PUAH+ [https://steamcommunity.com/sharedfiles/filedetails/?id=2034960453]
RimThreaded [https://steamcommunity.com/sharedfiles/filedetails/?id=2222907981]

@robinhood1596 robinhood1596 added Bug Something isn't working. Reproducible This issue is reproducible. labels Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. Reproducible This issue is reproducible.
Projects
None yet
Development

No branches or pull requests

1 participant