Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

energy_dispersion_to_migration doesn't produce a matrix as if starting directly from the events #272

Open
HealthyPear opened this issue Dec 6, 2023 · 1 comment
Labels
bug Something isn't working wrong behaviour No crashes, but something is not as it should be

Comments

@HealthyPear
Copy link
Member

When calling energy_dispersion_to_migration on a normalized energy dispersion histogram (right) I get a different
result than building the migration matrix directly from the data (center)

the right plot is a crosscheck with gammapy to_edisp_kernel, but in that case, one needs to choose a FoV offset angle (in this case I put 0 deg), but the first 2 plots have all offsets.

image

One culprit seems to be at least the fact that this function was not updated after #268

I suggest also improving the current units test to compare the 2 histograms.

@HealthyPear HealthyPear added the wrong behaviour No crashes, but something is not as it should be label Dec 6, 2023
@maxnoe
Copy link
Member

maxnoe commented Dec 6, 2023

I think this will be due to the energy_dispersion_to_migration function not being updated after the recent fix for the edisp normalization, see #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wrong behaviour No crashes, but something is not as it should be
Projects
None yet
Development

No branches or pull requests

2 participants