Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The WAVE presentation starts with the earliest video and audio sample #96

Open
yanj-github opened this issue Nov 29, 2024 · 2 comments
Open
Assignees
Labels
Released Released and ready for check

Comments

@yanj-github
Copy link
Collaborator

The WAVE presentation starts with the earliest video and audio sample that corresponds to the same presentation time as the earliest video sample.

This observation aims to verify that the audio and video start with the same media time. The comparison is made against the JS starting time, focusing on the following:

  • The media time of the first presented video frame.
  • The media time of the first audio segment.

If we allow the possibility of the starting audio being missed (or video missing), how should we define and implement a tolerance for this observation?

@jpiesing
Copy link

jpiesing commented Dec 2, 2024

This is a very good question.
I've tried several times to come up with a technical solution.
I lean towards a more structural solution, which is to disable the starting audio being missed / starting video being missed tolerance in video+audio observations for whichever is the later to start and instead use a new tolerance for this observation.
EDIT: I did think about using the same tolerance for missing audio at the start in an audio only test as for missing audio at the start in video+audio tests. After more thought, I think separate tolerances is better even if they're the same value.

@yanj-github yanj-github self-assigned this Dec 19, 2024
@yanj-github yanj-github added the In progress In progress label Dec 24, 2024
@yanj-github
Copy link
Collaborator Author

I have added earliest_sample_alignment_tolerance default to 60ms.
Here is the updated results:
image

yanj-github added a commit to yanj-github/device-observation-framework that referenced this issue Jan 15, 2025
yanj-github added a commit that referenced this issue Jan 15, 2025
yanj-github added a commit that referenced this issue Jan 15, 2025
@yanj-github yanj-github added Released Released and ready for check and removed In progress In progress labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released Released and ready for check
Projects
None yet
Development

No branches or pull requests

2 participants