-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put QR code container to top in pre test page #60
Comments
Do you have a picture of one example where the QR code is cut on the test page? I'm having difficulty imaging how this would happen. What element of the HTML page cuts the QR code? |
Sure, we have recorded the sessions. Will post image here later... Basically the problem is not that not another element is cutting/overlaying the qr code, but the qr code itself is floating partly outside the viewport |
@jpiesing fyi |
The QR code not being visible or partly outside the viewport may be slightly related to #43. Isn't it possible to scale the QR code so it fits? |
yes, it scaled here to the width, which was not want we wanted. Maybe better to scale it to the height and/or fix the font size of the upper elements and/or put the upper element to the bottom and the qr code first |
Why not scale it to the height? |
Sure, scaling to height could work as well. Much space is consumed by title "Next test is about to start" etc. hope qr code scaled to height is still readable when scaled to height |
At plugfest in Milan we faced issue that QR codes are cut in some cases on pre test page.
We could fix the problem by setting a fixed size for the QR code (300x300 pixels) but it may be better to show the QR code first and then followed by the title and path to test and other non relevant information for automatic processing
Propose to change order on element and put qr code container to top
tools/wave/www/pre-test.html
The text was updated successfully, but these errors were encountered: