Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize response body handling in logging middleware #156

Open
coderabbitai bot opened this issue Feb 6, 2025 · 0 comments
Open

Optimize response body handling in logging middleware #156

coderabbitai bot opened this issue Feb 6, 2025 · 0 comments
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2025

Currently, the logging middleware uses json.loads(response.body) to parse the response body for logging purposes. This approach is inefficient as it requires reading and parsing the response stream.

Proposed Solution

Use a custom response class to store the original response data, avoiding the need to re-parse the JSON. This can be implemented following the approach discussed in this FastAPI discussion.

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant