Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with upcoming ember 6.4 #45

Open
NullVoxPopuli opened this issue Feb 18, 2025 · 3 comments
Open

Not compatible with upcoming ember 6.4 #45

NullVoxPopuli opened this issue Feb 18, 2025 · 3 comments

Comments

@NullVoxPopuli
Copy link
Contributor

Running some select tests here:
https://github.com/NullVoxPopuli/ember-ecosystem-ci/actions/runs/13392210163/job/37402372122#step:5:735

@kevinkucharczyk
Copy link
Collaborator

@NullVoxPopuli is there a changelog for 6.4.0 available somewhere? Might help me track down what changed to break this addon.

@NullVoxPopuli
Copy link
Contributor Author

Ye! however, because most of glimmer-vm is considered private, we only keep track of that sort thing here: https://github.com/glimmerjs/glimmer-vm/releases

Here is the PR that actually landed the upgrade in ember-source: emberjs/ember.js#20842

tl;dr: we went from 0.92.x to 0.94.x

@kevinkucharczyk
Copy link
Collaborator

@NullVoxPopuli thanks for the pointers!

Some of the breakage seems to come down to this PR: glimmerjs/glimmer-vm#1646 and these changes:

Image

Previously, the append VM was exported as LowLevelVM, which allowed this addon to patch that VM class (

) and hook into when renders and rerenders happen.

After that PR, the exported LowLevelVM is the actual LowLevelVM, which means we can no longer call .updateWith.

I'm not yet sure what the most appropriate fix for this is - the VM class isn't exported from the package anymore, so we can't patch it. If you have any more suggestions, I'd love to hear them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants