Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit e85cd10 introduce a logic bug of ST_Covers #38

Open
cuteDen-ECNU opened this issue Dec 19, 2023 · 1 comment
Open

Commit e85cd10 introduce a logic bug of ST_Covers #38

cuteDen-ECNU opened this issue Dec 19, 2023 · 1 comment
Labels
fixed PostGIS sytax trans Add point to the boundary of geometry

Comments

@cuteDen-ECNU
Copy link
Owner

cuteDen-ECNU commented Dec 19, 2023

Consider the following statement:

SELECT ST_Covers(a1, a2) FROM ST_GeomFromText('MULTIPOLYGON(((1 0,0 1,-1 0,0 -1, 1 0)))') As a1, ST_GeomFromText('MULTIPOINT(EMPTY,(0 0)) ') As a2;
-- actual{f}, expected{t}

The result should be true, according to libgeos/geos#988.
It seems to be a regression bug.

git bisect helps find the introducing commit: e85cd10.

Using commit 66be3a6 to install PostGIS, the correct result can be obtained:

psql:script/simplify.sql:1: NOTICE:  lwgeom_api.c [352] called with n=0 and npoints=0
 st_covers 
-----------
 t
(1 row)

While when git checkout e85cd10, and install PostGIS, the incorrect result:

 st_covers 
-----------
 f
(1 row)

The version is the latest successful CI/CD build version.

 POSTGIS="3.5.0dev 3.4.0rc1-839-g61bc019eb" [EXTENSION] PGSQL="170" GEOS="3.13.0dev-CAPI-1.18.0" PROJ="8.2.1 NETWORK_ENABLED=OFF URL_ENDPOINT=https://cdn.proj.org USER_WRITABLE_DIRECTORY=/tmp/proj DATABASE_PATH=/usr/share/proj/proj.db" LIBXML="2.9.13" (core procs from "3.5.0dev 3.4.0rc1-750-g89fb96385" need upgrade)
@cuteDen-ECNU cuteDen-ECNU added PostGIS sytax trans Add point to the boundary of geometry reported labels Dec 19, 2023
@cuteDen-ECNU
Copy link
Owner Author

cuteDen-ECNU commented Dec 19, 2023

bugtracker link: https://trac.osgeo.org/postgis/ticket/5647
fix link: 6f63337
reproduce: e85cd10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed PostGIS sytax trans Add point to the boundary of geometry
Projects
None yet
Development

No branches or pull requests

1 participant