-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map-controls.png revision #236
Comments
FWIW this is what the blob looks like with mapbox removed:
Its not that long! so we would have two of these in our css |
I'm down with this idea -- we can provide the mapbox logo for watermarking as a separate image on mapbox hosting. |
Note that IE7 doesn't support data-uris, but maybe this doesn't matter? |
It doesn't but we can make a note of that in our docs and keep a copy of map-controls.png in the repo |
Closing. Added! |
Currently the map-controls.png looks like this: https://github.com/mapbox/wax/blob/a2b3f2bed8ca5e7cea87e007f9541084e9c2b1f7/theme/map-controls.png
I left the mapbox logo in there as I thought it may be necessary but I think we can cut this right?
This also raises a discussion made here in mapbox/mapbox.js#14
If we provided a different retina scaled png (we should probably do this in a css media query) this leaves us with another theme dependency to users using mapbox.js. I think removing the mapbox logo from the sprite and optimizing the size of the sprite overall might allow us to base64 encode the png
thoughts @yhahn ?
cc @tmcw
The text was updated successfully, but these errors were encountered: