Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make review page and test page UX's more similar? #76

Open
3 tasks
JonJagger opened this issue Aug 14, 2020 · 0 comments
Open
3 tasks

Make review page and test page UX's more similar? #76

JonJagger opened this issue Aug 14, 2020 · 0 comments

Comments

@JonJagger
Copy link
Member

JonJagger commented Aug 14, 2020

This task and #90 are a bit tangled together...

Currently, on the review page, there are separate filenames (in the lhs filelist) for stdout/stderr/status
These three are special as they do not show a diff. Is that what we want ?
IIRC, stdout/stderr/status did show diffs in the past, and it was a bit confusing and not helpful.
So, yes, I think this is what we want.

  • Maybe the test page should split out stdout/stderr/status to match the review page?
  • Have stdout/stderr/status as separate filenames (in the lhs filelist)?
  • Mark the stdout/stderr files with "(empty)" if they are empty? Thinking mostly of stderr here.
@JonJagger JonJagger changed the title Update review page UI to match test page Make review page and test page UX's more similar? Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant