Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise Support Composer implementation #10

Open
antonkomarev opened this issue Jun 29, 2019 · 0 comments
Open

Revise Support Composer implementation #10

antonkomarev opened this issue Jun 29, 2019 · 0 comments
Labels
enhancement New feature or request
Milestone
v2.0.0

Comments

@antonkomarev
Copy link
Member

antonkomarev commented Jun 29, 2019 •
edited
Loading

Need to refactor Composer support class methods install & uninstall. They shouldn't know anything about Job entity.

executeCommand doing too many things. It's doing JobFileRepository work. Maybe it will be better to make a new ProcessFileRepository class which will be responsible for process output read\write.
@antonkomarev antonkomarev modified the milestones: v1.0.0, Backlog Jun 29, 2019
@antonkomarev antonkomarev added the enhancement New feature or request label Jun 29, 2019
@antonkomarev antonkomarev modified the milestones: Backlog, v2.0.0 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@antonkomarev