From bf51acd40c8170c6b51ee6d57e44d88434d3466a Mon Sep 17 00:00:00 2001 From: Oliver Sanders Date: Thu, 8 Aug 2024 13:23:13 +0100 Subject: [PATCH 1/3] setup: types-pkg-resources -> types-setuptools (#620) --- setup.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.cfg b/setup.cfg index c8d7cf5d..e2287d34 100644 --- a/setup.cfg +++ b/setup.cfg @@ -103,7 +103,7 @@ tests = # https://github.com/pytest-dev/pytest/issues/12263 pytest>=6,<8.2 towncrier>=23 - types-pkg_resources>=0.1.2 + types-setuptools types-requests>2 all = %(hub)s From 32a5ef74c3586c512dfa1b9116fbde1d403b6226 Mon Sep 17 00:00:00 2001 From: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Date: Fri, 9 Aug 2024 14:42:02 +0100 Subject: [PATCH 2/3] Towncrier: check fragment names --- .github/workflows/test.yml | 3 +-- pyproject.toml | 1 + setup.cfg | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4236335d..d09123ae 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -79,8 +79,7 @@ jobs: run: mypy - name: Check changelog - if: startsWith(matrix.os, 'ubuntu') - run: towncrier build --draft + uses: cylc/release-actions/towncrier-draft@v1 - name: Test run: pytest diff --git a/pyproject.toml b/pyproject.toml index 9a583248..8eb18055 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -16,6 +16,7 @@ template = "changes.d/changelog-template.jinja" underlines = ["", "", ""] title_format = "## cylc-uiserver-{version} (Released {project_date})" issue_format = "[#{issue}](https://github.com/cylc/cylc-uiserver/pull/{issue})" +ignore = ["changelog-template.jinja"] # These changelog sections will be shown in the defined order: [[tool.towncrier.type]] diff --git a/setup.cfg b/setup.cfg index e2287d34..dc854014 100644 --- a/setup.cfg +++ b/setup.cfg @@ -102,7 +102,7 @@ tests = pytest-tornasync>=0.5.0 # https://github.com/pytest-dev/pytest/issues/12263 pytest>=6,<8.2 - towncrier>=23 + towncrier>=24.7.0 types-setuptools types-requests>2 all = From cd174df8d0d128754c173bd3406c9bd4bfb3b10a Mon Sep 17 00:00:00 2001 From: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Date: Fri, 9 Aug 2024 14:56:18 +0100 Subject: [PATCH 3/3] Add missing changelog entry --- changes.d/607.fix.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changes.d/607.fix.md diff --git a/changes.d/607.fix.md b/changes.d/607.fix.md new file mode 100644 index 00000000..ba5320f4 --- /dev/null +++ b/changes.d/607.fix.md @@ -0,0 +1 @@ +Log any errors when trying to list the workflow/job log files in the UI.