Is this unit test correctly implemented (should get a list of users by alpha (username, email) (fuzzy match))?

[wlsf82]

I was exploring the unit tests of the RWA, and I realized that this test describes that it should get a list of users by alpha (username, email) (fuzzy match), but, the implementation is searching by firstName instead (see https://github.com/cypress-io/cypress-realworld-app/blob/develop/src/__tests__/users.test.ts#L42.)

I just wanted to confirm if this is correct?

[wlsf82]

What about this one https://github.com/cypress-io/cypress-realworld-app/blob/develop/src/utils/__tests__/transactionUtils.test.ts#L134?

The previous ones on the same file that test getting query without something all have two expectations: passing some data + the status, and a second expectation only passing the status.

Shouldn't this be the case of this test too? I mean, shouldn't we have another expectation passing only the status here too?

[kevinold]

Hi @wlsf82,

Moved this over to a discussion. I'm certain the unit tests could be updated and feel free to play around with them and submit a PR if you arrive at corrections or additional assertions that could be added.

Our goal with these unit tests was to provide a minimum set of foundational unit tests when querying data from the lowdb database, since we do not have the features of a full ORM.

With this minimal set of unit tests in place, we were able to round out testing coverage using end-to-end tests.

For overall coverage of searching, you can refer to this Cypress test which covers this area of code from an end-to-end perspective -

cypress-realworld-app/cypress/tests/ui/new-transaction.spec.ts

Line 244 in 18f3b23

context("searches for a user by attribute", function () {

Hope this helps.

[wlsf82]

Thanks, @kevinold!