Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable database connection strings. #101

Open
ccampo133 opened this issue Jun 4, 2024 · 0 comments
Open

Configurable database connection strings. #101

ccampo133 opened this issue Jun 4, 2024 · 0 comments
Labels
enhancement New feature or request go Pull requests that update Go code good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ccampo133
Copy link
Contributor

Currently each database connection string is hardcoded in the respective sql.Repository implementation. This is a bit inflexible for users who have require more complicated database connections, such as configuring TLS or proxy settings. This is mitigated at least for Postgres since the driver allows for environment variables, although we're not so lucky for other

One option is to make the entire connection string as an input parameter. Another option would be to accept a set of key/values which we can append to the connection string. I'm open to suggestions here.

@ccampo133 ccampo133 added good first issue Good for newcomers help wanted Extra attention is needed enhancement New feature or request go Pull requests that update Go code labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant